Allow ModuleScopePlugin accecpts an array as its appSrc #4138
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
packages/react-dev-utils/README.md
Outdated
| @@ -57,7 +57,7 @@ module.exports = { | |||
| ``` | |||
|
|
|||
|
|
|||
| #### `new ModuleScopePlugin(appSrc: string, allowedFiles?: string[])` | |||
| #### `new ModuleScopePlugin(appSrc: string | string[], allowedFiles?: string[])` | |||
|
|
|||
| This Webpack plugin ensures that relative imports from app's source directory don't reach outside of it. | |||
There was a problem hiding this comment.
Should it be "source directories"?
There was a problem hiding this comment.
You're probably right. Thanks.
andriijas
added
tag: underlying tools
tag: internal
and removed
tag: underlying tools
labels
Allow ModuleScopePlugin accecpts an array as its appSrc (facebook#4138)
When ejected, you can now pass in an array as the appSrc for ModuleScopPlugin.
Implement of #4079
test plan:
yarn create-react-app test-appcd test-appyarn run ejectmkdir docsconfig/paths.js, adddocsSrc: resolveApp('docs')config/webpack.config.dev.js, modifynew ModuleScopePlugin(paths.appSrc, [paths.appPackageJson]),tonew ModuleScopePlugin([paths.appSrc, paths.docsSrc], [paths.appPackageJson]),yarn start. You should be able to import stuff from bothsrc/anddocs/.